Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for common/blobstore/retryableClient.go #6111

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

agautam478
Copy link
Contributor

@agautam478 agautam478 commented Jun 5, 2024

What changed?
Added tests for the common/blobstore/retryableClient.go

Why?
code coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

@@ -0,0 +1,156 @@
// The MIT License (MIT)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename the files to snake_case as we touch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! renaming.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.52%. Comparing base (294a120) to head (bcf1471).

Current head bcf1471 differs from pull request most recent head cfa1fca

Please upload reports for the commit cfa1fca to get more accurate results.

Additional details and impacted files

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 294a120...cfa1fca. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 018fea1b-bc74-46bc-9a77-44b66204fb65

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.04%) to 70.84%

Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 87.14%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/history/task/transfer_active_task_executor.go 2 72.77%
service/history/execution/mutable_state_util.go 2 78.52%
service/matching/tasklist/matcher.go 2 89.35%
service/matching/tasklist/task_reader.go 2 75.33%
common/task/fifo_task_scheduler.go 4 83.51%
service/matching/tasklist/task_list_manager.go 7 76.05%
Totals Coverage Status
Change from base Build 018fea0f-14e3-4984-94e0-5d6d068277b1: 0.04%
Covered Lines: 105511
Relevant Lines: 148942

💛 - Coveralls

@agautam478 agautam478 enabled auto-merge (squash) June 5, 2024 21:37
@agautam478 agautam478 merged commit 590500c into cadence-workflow:master Jun 5, 2024
17 of 18 checks passed
@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 018fea42-4f79-4e0c-8d5e-77958ecfaeb2

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.06%) to 70.866%

Files with Coverage Reduction New Missed Lines %
tools/cli/admin_db_decode_thrift.go 1 71.79%
service/history/queue/timer_queue_processor_base.go 1 77.66%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/task/parallel_task_processor.go 2 93.06%
service/matching/tasklist/task_reader.go 2 77.72%
service/history/handler/handler.go 3 96.2%
common/persistence/statsComputer.go 3 98.21%
service/history/task/fetcher.go 4 86.08%
service/history/task/transfer_standby_task_executor.go 6 86.33%
Totals Coverage Status
Change from base Build 018fea0f-14e3-4984-94e0-5d6d068277b1: 0.06%
Covered Lines: 105549
Relevant Lines: 148942

💛 - Coveralls

timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
…#6111)

* Added tests for common/blobstore/retryableClient.go

* Added tests for common/blobstore/retryableClient.go

* Added tests for common/blobstore/retryableClient.go

* Renamed the files into snake case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants