Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write more tests for replication task processor #6112

Conversation

taylanisikdemir
Copy link
Member

What changed?
Added tests for replication/task_processor.go

Why?
Improve coverage

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.58%. Comparing base (b38bd0c) to head (92ca080).
Report is 14 commits behind head on master.

Additional details and impacted files

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b38bd0c...92ca080. Read the comment docs.

@taylanisikdemir taylanisikdemir enabled auto-merge (squash) June 5, 2024 21:36
@taylanisikdemir taylanisikdemir merged commit a3f785a into cadence-workflow:master Jun 5, 2024
20 checks passed
@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 018fea4d-ed78-495f-8ed2-c45333c2d157

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 402 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.1%) to 70.682%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/config/config.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.66%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/task/parallel_task_processor.go 2 93.06%
service/history/task/transfer_active_task_executor.go 2 72.77%
service/history/execution/mutable_state_util.go 2 78.52%
common/persistence/statsComputer.go 3 98.21%
bench/lib/client.go 4 0.0%
service/matching/config/config.go 4 91.49%
service/history/task/fetcher.go 4 86.08%
service/history/task/transfer_standby_task_executor.go 6 86.94%
Totals Coverage Status
Change from base Build 018fea0f-14e3-4984-94e0-5d6d068277b1: -0.1%
Covered Lines: 105286
Relevant Lines: 148958

💛 - Coveralls

timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants