Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage exclusions #6115

Conversation

taylanisikdemir
Copy link
Member

What changed?

  • Exclude *Test.go files
  • Rename common/cache/interface_mocks.go to common/cache/interface_mock.go because that's the convention we use and exclude.

Why?
Improve coverage accuracy

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.93%. Comparing base (294a120) to head (0cb2670).
Report is 1 commits behind head on master.

Current head 0cb2670 differs from pull request most recent head 36ff81e

Please upload reports for the commit 36ff81e to get more accurate results.

Additional details and impacted files

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 294a120...36ff81e. Read the comment docs.

@taylanisikdemir taylanisikdemir enabled auto-merge (squash) June 5, 2024 21:47
@taylanisikdemir taylanisikdemir merged commit 1cb086d into cadence-workflow:master Jun 5, 2024
18 checks passed
@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 018fea5f-0e39-40b3-aa6d-5d7e6d72c31a

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.01%) to 70.813%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.66%
service/matching/tasklist/task_list_manager.go 2 77.05%
common/persistence/statsComputer.go 3 98.21%
service/history/task/transfer_standby_task_executor.go 6 86.33%
Totals Coverage Status
Change from base Build 018fea0f-14e3-4984-94e0-5d6d068277b1: 0.01%
Covered Lines: 105470
Relevant Lines: 148942

💛 - Coveralls

timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants