Fix encoding bug to index context header in search attributes #6148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
Jun 26, 2024
| searchAttr = appendContextHeaderToSearchAttributes(searchAttr, attributes.Header.Fields, t.config.ValidSearchAttributes()) | ||
| // fail open to avoid blocking the task processing | ||
| if newSearchAttr, err := appendContextHeaderToSearchAttributes(searchAttr, attributes.Header.Fields, t.config.ValidSearchAttributes()); err != nil { | ||
| t.logger.Error("unable to parse search attributes", tag.Error(err)) |
There was a problem hiding this comment.
nit: inconsistent error message in active/passive executors. I'd go with: "failed to add headers to search attributes"
| @@ -1978,8 +1979,12 @@ func createRecordWorkflowExecutionStartedRequest( | |||
| } | |||
| var searchAttributes map[string][]byte | |||
| if enableContextHeaderInVisibility { | |||
| contextValueJsonString, err := json.Marshal("contextValue") | |||
| if err != nil { | |||
| panic(err) // must not happen in tests | |||
There was a problem hiding this comment.
nit: pass testing.T here and call t.Fatal instead of panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
json marshal raw string bytes before store in search attributes
Why?
Context Header stores the raw string bytes; but search attributes should store json strings rather than raw string bytes. Otherwise, it will cause unmarshal error in creating visibility message.
How did you test it?
unit test
Potential risks
Release notes
Documentation Changes