-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure PR description contains compatibility info & rollout plan when DB schema is changed #6150
Merged
taylanisikdemir
merged 14 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/schema_change_reminder
Jul 1, 2024
Merged
Ensure PR description contains compatibility info & rollout plan when DB schema is changed #6150
taylanisikdemir
merged 14 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/schema_change_reminder
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 01906f63-55bd-433b-bb88-db8bfd7cbb54Details
💛 - Coveralls |
taylanisikdemir
changed the title
Detect schema change and warn
Ensure PR description contains critical information when DB schema is changed
Jul 1, 2024
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
July 1, 2024 19:11
taylanisikdemir
changed the title
Ensure PR description contains critical information when DB schema is changed
Ensure PR description contains compatibility info & rollout plan when DB schema is changed
Jul 1, 2024
demirkayaender
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked offline. Looks good after the comments.
Groxx
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, reasonably-loose verification, and pretty easy to replicate to new templates. 👍 I like it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding a new github workflow to run on schema changes and fails if the PR template is missing critical information.
Why?
To warn the developer about potential breaking changes.
How did you test it?
Made some changes under schema/ folder and validated the new github workflow fails. See screenshot: