bugfix: bad dynamicconfig filter/string mapping #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groxx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Groxx
commented
Jul 2, 2024
Comment on lines
-34
to
+37
| if f <= UnknownFilter || f > WorkflowID { | ||
| return filters[UnknownFilter] | ||
| if f > UnknownFilter && int(f) < len(filters) { | ||
| return filters[f] | ||
| } | ||
| return filters[f] | ||
| return filters[UnknownFilter] |
There was a problem hiding this comment.
previously missed both workflowType and ratelimitKey 😢
Pull Request Test Coverage Report for Build 019070d4-f837-4f0d-bc9f-a372952d8109Details
💛 - Coveralls |
3vilhamster
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic desperately needs to be refactored, it's incredibly error-prone :\
We should probably just use enumer's codegen tbh. Or something similar.
Previously
String()missed bothworkflowTypeandratelimitKey.The
String()impl is now rewritten so it won't be missed with future additions, and there's a test to check it too.