Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a zero bucket, zeros are being reported as 1 #6153

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Groxx
Copy link
Member

@Groxx Groxx commented Jul 2, 2024

With a min bucket of 1, a 0 is reported as a 1, which is quite misleading for this kind of use.

Sorta obvious in retrospect, but we have so few histograms anywhere that I apparently don't have any safe habits built up.

@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 019074a7-be79-43e7-b97d-7674d472b3a6

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 48 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.02%) to 71.505%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/matching/tasklist/task_list_manager.go 2 77.05%
service/frontend/api/handler.go 2 75.62%
service/history/task/transfer_standby_task_executor.go 3 86.23%
service/history/task/task.go 3 84.81%
common/persistence/nosql/nosql_task_store.go 3 85.52%
common/task/fifo_task_scheduler.go 3 84.54%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/history/execution/cache.go 6 74.61%
service/history/task/task_util.go 20 60.29%
Totals Coverage Status
Change from base Build 01907465-3a13-43f8-89cc-21fc60d6d529: -0.02%
Covered Lines: 105293
Relevant Lines: 147252

💛 - Coveralls

@Groxx Groxx merged commit 6e8d0f3 into cadence-workflow:master Jul 2, 2024
19 checks passed
@Groxx Groxx deleted the zero-bucket branch July 2, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants