Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the ratelimiter collections when stopping the service #6155

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Groxx
Copy link
Member

@Groxx Groxx commented Jul 2, 2024

Rather obviously missed in retrospect, oops.

These can be stopped basically anywhere without causing issues, but after the handlers are stopped there should be no more in-bound requests worth counting (the "stopping" check will stop anything from actually "running").
So around here seems like the most-reasonable place to stop sharing load info with others.

@Groxx Groxx disabled auto-merge July 2, 2024 21:42
@Groxx Groxx enabled auto-merge (squash) July 2, 2024 21:42
@Groxx Groxx merged commit 62ae2da into cadence-workflow:master Jul 2, 2024
19 checks passed
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 01907562-f5f0-40b6-8908-451d758b6138

Details

  • 9 of 17 (52.94%) changed or added relevant lines in 1 file are covered.
  • 22 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.003%) to 71.512%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/frontend/service.go 9 17 52.94%
Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
tools/cli/admin_db_decode_thrift.go 2 70.51%
service/matching/tasklist/matcher.go 2 90.91%
common/persistence/historyManager.go 2 66.67%
service/history/task/transfer_standby_task_executor.go 3 86.64%
common/persistence/statsComputer.go 3 98.18%
service/history/shard/context.go 9 78.13%
Totals Coverage Status
Change from base Build 019074f6-fb21-4003-bd1e-30edc2b1e424: 0.003%
Covered Lines: 105315
Relevant Lines: 147269

💛 - Coveralls

@Groxx Groxx deleted the stop-limiters branch July 3, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants