Add activity timeout context #6156
Conversation
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -93,6 +94,11 @@ func WorkflowTimeoutType(timeoutType int64) Tag { | |||
| return newInt64("wf-timeout-type", timeoutType) | |||
| } | |||
|
|
|||
| // ActivityTimeoutType returns tag for ActivityTimeoutType | |||
| func ActivityTimeoutType(timerType shared.TimeoutType) Tag { | |||
There was a problem hiding this comment.
nit: you can cast timer type to string and pass here to avoid depending on shared package in log package. I guess it's ok to depend on it here because all callers of log package is probably already importing shared.
There was a problem hiding this comment.
I considered it more type-safe, so people pass the expected data, not just a string (though the data is actually a string)
What changed?
I've introduced a new tag type and aded context on which timer caused activity timeout.
Why?
To improve observabitlity of activity timing out and investigating activity issues.
How did you test it?
Unit tests.
Potential risks
Release notes
Documentation Changes