Add ES support for ListAllWorkflowExecutions #6157
Conversation
sankari165
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -445,7 +444,38 @@ func (v *esVisibilityStore) ListWorkflowExecutions( | |||
| } | |||
|
|
|||
| func (v *esVisibilityStore) ListAllWorkflowExecutions(ctx context.Context, request *p.InternalListAllWorkflowExecutionsByTypeRequest) (*p.InternalListWorkflowExecutionsResponse, error) { | |||
| return nil, p.ErrVisibilityOperationNotSupported | |||
| isRecordValid := func(rec *p.InternalVisibilityWorkflowExecutionInfo) bool { | |||
| return !request.EarliestTime.After(rec.StartTime) && !rec.StartTime.After(request.LatestTime) | |||
There was a problem hiding this comment.
I guess this should also be covered with tests
There was a problem hiding this comment.
LGTM.
Side note: do we want to onboard to using query builders, like https://github.com/defensestation/osquery or https://github.com/aquasecurity/esquery
What changed?
ES support for ListAllWorkflowExecutions
Why?
ES is still used in many clusters and we need support for ListAllWorkflowExecutions
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes