Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "make build" behavior clearer, it is rather special case #6166

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

Groxx
Copy link
Member

@Groxx Groxx commented Jul 15, 2024

It sounded a bit too general purpose for what it actually did.

While I was at it, I rewrote some of the make-help-docs and made it easier to adjust what appears "above the fold".

@Groxx
Copy link
Member Author

Groxx commented Jul 15, 2024

Docs are now:

❯ make
bins                 Build all binaries, and any fast codegen needed (does not refresh wrappers or mocks)
help                 Prints a help message showing any specially-commented targets
pr                   Redo all codegen and basic checks, to ensure your PR will be able to run tests.  Recommended before opening a github PR
-----------------------------------
build                `go build` all packages and tests (a quick compile check only, skips all other steps)
clean                Clean build products
copyright            Update copyright headers
deps                 Check for dependency updates, for things that are directly imported
deps-all             Check for all dependency updates
fmt                  Run `gofmt` / organize imports / etc
go-generate          Run `go generate` to regen mocks, enums, etc
lint                 (Re)run the linter
release              Re-generate generated code and run tests
test                 Build and run all tests locally
tidy                 `go mod tidy` all packages

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.67%. Comparing base (3248455) to head (43c1e9f).

Additional details and impacted files

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3248455...43c1e9f. Read the comment docs.

@Groxx Groxx merged commit 8664922 into cadence-workflow:master Jul 16, 2024
20 checks passed
@Groxx Groxx deleted the makebuild-help branch July 16, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants