Bug fix: custom query in Count doesn't return correct result #6179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
CountQuery used to return an empty string when there are errors in the query and then log the error. Changed it to return error instead of log.
Also updated tests in PinotQueryValidator and pinot_visibility_store
Why?
When a custom query has something like "CustomKeywordField = missing", the list APIs will return errors because "xxx = missing" is only supported for system keys. (Same for ES) In the current situation, the custom query in count return an empty string and thus Cadence will have a wrong result. This needs to be changed.
How did you test it?
unit test
Potential risks
Release notes
Documentation Changes