Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: custom query in Count doesn't return correct result #6179

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

bowenxia
Copy link
Contributor

@bowenxia bowenxia commented Jul 19, 2024

What changed?
CountQuery used to return an empty string when there are errors in the query and then log the error. Changed it to return error instead of log.
Also updated tests in PinotQueryValidator and pinot_visibility_store

Why?
When a custom query has something like "CustomKeywordField = missing", the list APIs will return errors because "xxx = missing" is only supported for system keys. (Same for ES) In the current situation, the custom query in count return an empty string and thus Cadence will have a wrong result. This needs to be changed.

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.76%. Comparing base (4a51fb4) to head (b8f662f).

Additional details and impacted files
Files Coverage Δ
common/persistence/pinot/pinot_visibility_store.go 93.47% <88.88%> (+0.31%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a51fb4...b8f662f. Read the comment docs.

@bowenxia bowenxia merged commit 33d93e0 into master Jul 22, 2024
21 checks passed
@bowenxia bowenxia deleted the xbowen_custom_count_query_return_error branch July 22, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants