Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global ratelimiter: improved shadow-limiter accounting #6191

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

Groxx
Copy link
Member

@Groxx Groxx commented Jul 26, 2024

Comments in code describe most of the details and reasoning, and they're in code
rather than this commit message because they need to be kept in mind when touching
this implementation.

Test changes include a "actually use reserve, oops" fix and a new test which failed
previously (shadow was counted as idle, because it had not used any tokens, because
it was canceled and returned).

Comments in code describe most of the details and reasoning, and they're in code
rather than this commit message because they need to be kept in mind when touching
this implementation.
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.87%. Comparing base (f3350d0) to head (43a3dc5).

Additional details and impacted files
Files Coverage Δ
...mmon/quotas/global/collection/internal/shadowed.go 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3350d0...43a3dc5. Read the comment docs.

@Groxx Groxx merged commit e60d167 into cadence-workflow:master Jul 29, 2024
20 checks passed
@Groxx Groxx deleted the cancel-metrics branch July 29, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants