Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a wait time for pollers #6215

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Aug 7, 2024

What changed?
Add a wait time for pollers

Why?
We've observed pollers being forwarded even though there are tasks in the backlog of local partition. Forwarding is more expensive and has higher latency, so we add a wait time to reduce the number of poll forwarding.

How did you test it?
manual tests

Potential risks
No risk. This is protected by a dynamicconfig.

Release notes

Documentation Changes

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 98.38710% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.86%. Comparing base (f2d0afb) to head (5fb7f5f).
Report is 3 commits behind head on master.

Files Patch % Lines
service/matching/tasklist/matcher.go 98.27% 1 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
service/matching/config/config.go 100.00% <100.00%> (ø)
service/matching/tasklist/task_list_manager.go 67.16% <100.00%> (+0.24%) ⬆️
service/matching/tasklist/matcher.go 62.28% <98.27%> (-16.53%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2d0afb...5fb7f5f. Read the comment docs.

@Shaddoll Shaddoll force-pushed the poller-wait branch 2 times, most recently from 9594099 to 238d813 Compare August 8, 2024 01:48
Copy link
Member

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Though, one day we'll need to invest into migration of time related tests to mocked time. I'm not sure how flatly it can be 😅

@Shaddoll Shaddoll merged commit 8f3b119 into cadence-workflow:master Aug 9, 2024
19 checks passed
@Shaddoll Shaddoll deleted the poller-wait branch August 9, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants