Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] Timeout invariant to identify and collect all timeouts in a workflow execution #6220

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

sankari165
Copy link
Member

@sankari165 sankari165 commented Aug 9, 2024

What changed?
Introducing an invariant interface that can check and collect issues in a workflow. timeout is one invariant that identifies timeouts within a workflow execution history.

The execution history input is kept out of the interface definition since not all invariants will rely on the workflow execution data.

Each invariant will need different data input based on what issues they identify.

This usage of this interface will be a workflow within the worker service

Why?
This invariant will be used within the workflow diagnostics to run checks to identify timeouts in workflow execution

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 84.26966% with 14 lines in your changes missing coverage. Please review.

Project coverage is 72.95%. Comparing base (38d8ef6) to head (23d5d2b).

Files Patch % Lines
service/worker/diagnostics/invariants/timeout.go 84.26% 13 Missing and 1 partial ⚠️
Additional details and impacted files
Files Coverage Δ
service/worker/diagnostics/invariants/timeout.go 84.26% <84.26%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38d8ef6...23d5d2b. Read the comment docs.

@sankari165 sankari165 merged commit ef5dbee into cadence-workflow:master Aug 9, 2024
19 checks passed
@sankari165 sankari165 deleted the CDNC-10129-invariant branch August 9, 2024 11:27
@sankari165 sankari165 changed the title Timeout invariant to identify and collect all timeouts in a workflow execution [Wf-Diagnostics] Timeout invariant to identify and collect all timeouts in a workflow execution Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants