Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] setup a workflow that performs the diagnostics for a given workflow #6225

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

sankari165
Copy link
Member

What changed?
New workflow in cadence worker service that fetches execution history and uses the invariants to diagnose a workflow. This new workflow will be triggered via cli for testing purposes. Follow up tasks will introduce an API in frontend to trigger this w/f.

This PR aims to introduce the workflow setup and will be followed by updates to improve the workflow implementation

Why?
This workflow will be used to diagnose workflows for cadence users

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.90%. Comparing base (8f3b119) to head (2c5d9c9).
Report is 6 commits behind head on master.

Files Patch % Lines
service/worker/diagnostics/workflow.go 90.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files Coverage Δ
service/worker/diagnostics/activities.go 100.00% <100.00%> (ø)
service/worker/diagnostics/module.go 100.00% <100.00%> (ø)
service/worker/diagnostics/workflow.go 90.47% <90.47%> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3b119...2c5d9c9. Read the comment docs.

@sankari165 sankari165 merged commit 952af5a into cadence-workflow:master Aug 14, 2024
19 checks passed
@sankari165 sankari165 deleted the CDNC-10126 branch August 14, 2024 12:32
@sankari165 sankari165 changed the title setup a workflow that performs the diagnostics for a given workflow [Wf-Diagnostics] setup a workflow that performs the diagnostics for a given workflow Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants