Update parameter of simulation test #6226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
Aug 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
natemort
reviewed
Aug 13, 2024
| generatedTasksCounter *int32, | ||
| lastTaskScheduleID *int32, | ||
| wg *sync.WaitGroup) { | ||
| defer wg.Done() | ||
|
|
||
| t := time.NewTicker(taskGenerateInterval) | ||
| defer t.Stop() | ||
|
|
||
| for { | ||
| select { | ||
| case <-ctx.Done(): |
There was a problem hiding this comment.
Nit: I think we can remove this since we handle checking if the context is done via the rateLimiter.Wait call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
The new parameter is more straightforward to control the load of traffic.
How did you test it?
Potential risks
Release notes
Documentation Changes