-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wf-Diagnostics] Rootcause issues causing timeouts #6236
[Wf-Diagnostics] Rootcause issues causing timeouts #6236
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
return InvariantRootCauseResult{ | ||
RootCause: RootCauseTypeHeartBeatingNotEnabled.String(), | ||
Metadata: []byte(metadata.TimeElapsed.String()), | ||
}, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This suppose to hit a lot - lots of activity calls don't use heartbeats.
Are you taking into account it is not as crucial as not the next if-statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no prioritisation done here. we simply list potential root causes cos we cant quite predict what suits the usecase. but calling out heart beating not enabled is one of the many observations we return when an activity times out.
What changed?
Timeout invariant now has a method that provides a list of potential root causes for the identified issues. Pollers and heart beating checks are added to begin with. More rootcause checks will be added in future PRs
Why?
Timeouts are usually caused by missing pollers and activity timeouts specifically could be due to missing heartbeating config. These are checked as potential root causes.
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes