Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] update diagnostics workflow to get rootcause for identified issues #6244

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

sankari165
Copy link
Member

@sankari165 sankari165 commented Aug 21, 2024

What changed?
Diagnostic workflow now has an additional activity to rootcause the identified timeouts. Follow up PR will combine identified issues and their rootcause to provide diagnostics report in json format

Why?
Provide potential rootcause to the users for the identified timeouts

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.94%. Comparing base (69d0ce7) to head (01a8a52).
Report is 3 commits behind head on master.

Files Patch % Lines
service/worker/diagnostics/workflow.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files Coverage Δ
service/worker/diagnostics/activities.go 100.00% <100.00%> (ø)
service/worker/diagnostics/module.go 100.00% <100.00%> (ø)
service/worker/diagnostics/workflow.go 87.09% <75.00%> (-4.21%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69d0ce7...01a8a52. Read the comment docs.

@sankari165 sankari165 merged commit 14ae23e into cadence-workflow:master Aug 22, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-10127-rootcause branch August 22, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants