-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify blob size limit breach logging and metering #6250
Unify blob size limit breach logging and metering #6250
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
taskToken.DomainID, | ||
domainName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really makes me wish we had a common name-and-id pair :| we have access to both almost everywhere...
that'd be a bigger change tho, so 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. We do have a domain cache, but it is not propagated everywhere. I f we used DI, we could separate this component and make sure that domain cache is provided, but we don't for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small Qs and nits but overall LGTM. Seems fine to merge as-is, everything's optional and only if you agree :)
What changed?
I introduced a new log and metric for the blob size limit breach.
Why?
We want to track blob size violations for each domain and be able to identify all failed workflows.
How did you test it?
Unit tests.
Potential risks
For misconfigured domains we can introduce a lot of logs, but that is not expected state.
Release notes
Introduced new metric for blob size violations:
blob_size_exceed_limit that can point to issues for a specific domain and operation.
Documentation Changes