Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] remove heartbeat rootcause for other irrelevant timeouts #6253

Merged

Conversation

sankari165
Copy link
Member

What changed?
Update the way wf-diagnostics provides heart beating as a solution for activity timeouts

Why?
Rootcause mentioning heartbeat is not relevant for schedule to start timeouts or for non heartbeat timeouts with heart beating enabled

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@sankari165 sankari165 enabled auto-merge (squash) August 26, 2024 14:34
@sankari165 sankari165 merged commit fbae51a into cadence-workflow:master Aug 26, 2024
18 checks passed
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.99%. Comparing base (630013c) to head (ab2aaab).
Report is 1 commits behind head on master.

Files Patch % Lines
service/worker/diagnostics/invariants/timeout.go 93.33% 1 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
service/worker/diagnostics/invariants/timeout.go 86.20% <93.33%> (+3.59%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 630013c...ab2aaab. Read the comment docs.

@sankari165 sankari165 deleted the CDNC-10131-heartbeating branch August 27, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants