Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topic tag to producer metrics #6254

Add topic tag to producer metrics

1c18eee
Select commit
Loading
Failed to load commit list.
Merged

Add topic tag to producer metrics #6254

Add topic tag to producer metrics
1c18eee
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 26, 2024 in 0s

73.00% (target 85.00%)

View this Pull Request on Codecov

73.00% (target 85.00%)

Details

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.00%. Comparing base (fbae51a) to head (1c18eee).

Files Patch % Lines
common/messaging/kafka/client_impl.go 0.00% 2 Missing ⚠️
common/messaging/metrics_producer.go 92.85% 1 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
common/asyncworkflow/queue/kafka/queue.go 82.60% <100.00%> (+1.21%) ⬆️
common/messaging/metrics_producer.go 81.81% <92.85%> (ø)
common/messaging/kafka/client_impl.go 18.29% <0.00%> (-0.23%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbae51a...1c18eee. Read the comment docs.