Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid retry when deletes non exists visibility message #6260

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented Aug 29, 2024

What changed?
Check if GenericBulkableRequest is delete request to avoid retry during migration

Why?
This can happen during migration from ES to OS.
The doc can be deleted during double writes, but it doesn't exist in the destination source, it will nack the kafka message and keep retrying

How did you test it?
Unit test
Tested in dev manually

Potential risks

Release notes

Documentation Changes

@neil-xie neil-xie changed the title Avoid retry when deletes non exists visibility message Avoid retry storm when deletes non exists visibility message Aug 29, 2024
@neil-xie neil-xie changed the title Avoid retry storm when deletes non exists visibility message Avoid retry when deletes non exists visibility message Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.06%. Comparing base (1b02d78) to head (efa3133).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
service/worker/indexer/esProcessor.go 76.47% 3 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
service/worker/indexer/esProcessor.go 74.19% <76.47%> (+0.66%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b02d78...efa3133. Read the comment docs.

@neil-xie neil-xie merged commit f6e4360 into cadence-workflow:master Sep 4, 2024
20 checks passed
@neil-xie neil-xie deleted the CDNC-10449 branch September 4, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants