Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for wrapped errors in matchings error handler #6263

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Sep 3, 2024

What changed?

  • Added test for handleErr
  • Added support for wrapped errors in handleErr

Why?
Some errors are not recognized correctly because they are wrapped, with the introduction of wrapped errors in go we should never check the type directly

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.05%. Comparing base (3f1f3a6) to head (54be7a5).
Report is 1 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
service/matching/handler/context.go 100.00% <100.00%> (+56.36%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f1f3a6...54be7a5. Read the comment docs.

@jakobht jakobht merged commit 05852ef into cadence-workflow:master Sep 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants