-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce weighted load balancer #6315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
September 28, 2024 05:26
Shaddoll
force-pushed
the
weight
branch
4 times, most recently
from
September 29, 2024 03:23
1fdda69
to
619be96
Compare
Shaddoll
changed the title
wip: Introduce weighted load balancer
Introduce weighted load balancer
Oct 3, 2024
taylanisikdemir
approved these changes
Oct 4, 2024
pw.initialized = true | ||
} | ||
|
||
func NewWeightedLoadBalancer( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend adding a background ticker to log weights. (need to add start/stop to load balancer interface for this.)
This will help a lot for debugging in prod. Global rate limiter is missing this and we are having hard time debugging edge cases.
Shaddoll
added a commit
to Shaddoll/cadence
that referenced
this pull request
Oct 16, 2024
This reverts commit 5b92d52.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Introduce a weighted load balancer to matching client
Why?
See the documentation in the PR.
This loadbalancer is better than the previous 2 implementations.
How did you test it?
unit test, and also verified in dev environment
Potential risks
Release notes
Documentation Changes