Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new type MatchingPollForActivityTaskResponse #6325

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Oct 3, 2024

Detailed Description
Introduce new type MatchingPollForActivityTaskResponse to differentiate the activity poller responses from matching and frontend. We want to update the matching response to include some metadata of the tasklist which are not exposed to customers.

Impact Analysis

  • Backward Compatibility: This is backward compatible because it only changes the internal type.
  • Forward Compatibility: This is forward compatible because it only changes the internal type.

Testing Plan

  • Unit Tests: We have unit tests in common/types folder.
  • Persistence Tests: It doesn't change persisted data.
  • Integration Tests: The existing integration tests cover the change.
  • Compatibility Tests: The test is both backward compatible and forward compatible since it doesn't change the gprc or thrift type.

Rollout Plan

  • What is the rollout plan?
  • Does the order of deployment matter? No.
  • Is it safe to rollback? Does the order of rollback matter? It's safe to rollback. Order doesn't matter.
  • Is there a kill switch to mitigate the impact immediately? n/a

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 97.18310% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.60%. Comparing base (ea3a90e) to head (a43c43a).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
service/matching/handler/engine.go 60.00% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
client/matching/client.go 89.47% <100.00%> (ø)
common/types/mapper/proto/matching.go 95.34% <100.00%> (ø)
common/types/mapper/thrift/matching.go 99.30% <100.00%> (+0.11%) ⬆️
common/types/matching.go 0.00% <ø> (ø)
service/frontend/api/handler.go 66.88% <100.00%> (+0.89%) ⬆️
service/matching/handler/handler.go 100.00% <100.00%> (ø)
service/matching/tasklist/task.go 78.33% <100.00%> (ø)
service/matching/handler/engine.go 79.89% <60.00%> (ø)

... and 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3a90e...a43c43a. Read the comment docs.

@@ -581,7 +582,24 @@ func (wh *WorkflowHandler) PollForActivityTask(
return nil, err
}
}
return resp, nil
return &types.PollForActivityTaskResponse{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may miss to update here when new fields are added. better to define From/To funcs and have unit tests.

@Shaddoll Shaddoll merged commit d4884cc into cadence-workflow:master Oct 4, 2024
21 checks passed
@Shaddoll Shaddoll deleted the idl branch October 4, 2024 19:55
Shaddoll added a commit to Shaddoll/cadence that referenced this pull request Oct 14, 2024
Shaddoll added a commit to Shaddoll/cadence that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants