-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new type MatchingPollForActivityTaskResponse #6325
Conversation
124ce07
to
aa715cf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 33 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
6e5b755
to
550016f
Compare
@@ -581,7 +582,24 @@ func (wh *WorkflowHandler) PollForActivityTask( | |||
return nil, err | |||
} | |||
} | |||
return resp, nil | |||
return &types.PollForActivityTaskResponse{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may miss to update here when new fields are added. better to define From/To funcs and have unit tests.
…ce-workflow#6325)" This reverts commit d4884cc.
…ce-workflow#6325)" This reverts commit d4884cc.
Detailed Description
Introduce new type MatchingPollForActivityTaskResponse to differentiate the activity poller responses from matching and frontend. We want to update the matching response to include some metadata of the tasklist which are not exposed to customers.
Impact Analysis
Testing Plan
Rollout Plan