Add missing fields to WorkflowExecutionStartedEventAttributes #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Apr 2, 2018
| 20: optional TaskList taskList | ||
| 30: optional binary input | ||
| 40: optional i32 executionStartToCloseTimeoutSeconds | ||
| 50: optional i32 taskStartToCloseTimeoutSeconds | ||
| 52: optional ChildPolicy childPolicy |
There was a problem hiding this comment.
if the "child policy" represents what this workflow's parent want this workflow to do, then we should use a better name
There was a problem hiding this comment.
We are keeping our API as close to SWF as possible: https://docs.aws.amazon.com/amazonswf/latest/apireference/API_WorkflowExecutionStartedEventAttributes.html
wxing1292
reviewed
Apr 2, 2018
| @@ -812,6 +817,7 @@ struct StartWorkflowExecutionRequest { | |||
| 80: optional string identity | |||
| 90: optional string requestId | |||
| 100: optional WorkflowIdReusePolicy workflowIdReusePolicy | |||
| 110: optional ChildPolicy childPolicy | |||
wxing1292
reviewed
Apr 2, 2018
| historyEvent := b.msBuilder.createNewHistoryEvent(workflow.EventTypeWorkflowExecutionStarted) | ||
| attributes := &workflow.WorkflowExecutionStartedEventAttributes{} | ||
| attributes.WorkflowType = request.WorkflowType | ||
| attributes.TaskList = request.TaskList | ||
| attributes.Input = request.Input | ||
| attributes.ExecutionStartToCloseTimeoutSeconds = common.Int32Ptr(*request.ExecutionStartToCloseTimeoutSeconds) | ||
| attributes.TaskStartToCloseTimeoutSeconds = common.Int32Ptr(*request.TaskStartToCloseTimeoutSeconds) | ||
| attributes.ChildPolicy = request.ChildPolicy | ||
| attributes.ContinuedExecutionRunId = previousRunID |
There was a problem hiding this comment.
previous run ID is better than ContinuedExecutionRunId, i assume
wxing1292
reviewed
Apr 2, 2018
| @@ -875,7 +875,7 @@ func (e *mutableStateBuilder) AddWorkflowExecutionStartedEventForContinueAsNew(d | |||
|
|
|||
| createRequest := &workflow.StartWorkflowExecutionRequest{ | |||
| RequestId: common.StringPtr(uuid.New()), | |||
| Domain: common.StringPtr(previousExecutionState.executionInfo.DomainID), | |||
| Domain: common.StringPtr(domainName), | |||
samarabbas
force-pushed
the
parent-execution-info
branch
from
442d519 to
060d307
Compare
WorkflowExecutionStartedEventAttributes now also has support for parent execution info, child policy and continued execution run id. fixes cadence-workflow#425
samarabbas
force-pushed
the
parent-execution-info
branch
from
060d307 to
3087dea
Compare
wxing1292
approved these changes
Apr 2, 2018
|
this is a complete rip off of aws swf, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkflowExecutionStartedEventAttributes now also has support for parent
execution info, child policy and continued execution run id.
fixes #425