Batcher will now by default retry it's activity 5 times #6534
+345
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
jakobht
force-pushed
the
makeBatcherMoreReliable
branch
from
38f0285
to
e7c0266
Compare
After retrying 5 times the whole workflow will retry, ensuring any bad state is cleared. The change should be safe as old CLI clients will default to the old behaviour of retrying forever.
jakobht
force-pushed
the
makeBatcherMoreReliable
branch
from
e7c0266
to
2e39fc2
Compare
dkrotx
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The batcher activity will now retry 5 times by default, instead of forever.
After 5 retries the whole workflow will be retried, insuring any bad state in the heartbeat state is cleared.
The retry policy for the workflow is controlled by the CLI. If the workflow is triggered from an old CLI the workflow will work as before this commit. If the workflow is trigered from the new CLI, it will do the new behaviour with 5 times retry.
The change should be safe as old CLI clients will default to the old
behaviour of retrying forever.
Also:
Why?
In an incident we had the activity retry forever with bad state. The workflow never recovered or progessed from this.
This change should let the workflow recover in these situations.
How did you test it?
Unit tested, and tested in staging environment.
Potential risks
Release notes
Documentation Changes