Fix long poll cancellation #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
commented
Dec 2, 2024
| @@ -152,6 +152,8 @@ func (c *clientImpl) PollForActivityTask( | |||
| partition, | |||
| resp.LoadBalancerHints, | |||
| ) | |||
| // caller needs to know the actual partition for cancelling long poll, so modify the request to pass this information | |||
There was a problem hiding this comment.
I don't like this pattern. I think we should return the partition explicitly to the caller, but for a quick fix, I'll go with this way.
taylanisikdemir
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Fix bugs
How did you test it?
eye ball check
Potential risks
Release notes
Documentation Changes