Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ut state builder #808

Merged
merged 10 commits into from
Jun 11, 2018
Merged

Ut state builder #808

merged 10 commits into from
Jun 11, 2018

Conversation

wxing1292
Copy link
Contributor

@wxing1292 wxing1292 commented Jun 2, 2018

separate mutable state into interface && implementation, so we can mock it.
unit test state builder
fix bug when continue as new, new ms builder is not updated with replication state.

partially solve #791

@wxing1292 wxing1292 requested a review from samarabbas June 2, 2018 00:43
@wxing1292 wxing1292 force-pushed the ut-state-builder branch 2 times, most recently from 2c3b52d to 202cac1 Compare June 7, 2018 18:56
Copy link
Contributor

@samarabbas samarabbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wxing1292 wxing1292 merged commit 1a167d7 into master Jun 11, 2018
@wxing1292 wxing1292 deleted the ut-state-builder branch June 11, 2018 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants