Fix missing decision timeout for transient decisions #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc-zz
approved these changes
Jun 26, 2018
We were using incorrect scheduleID for transient decisions on decision started event. This happens if a new event comes in after a transient decision is scheduled, but before it is started. We end up a creating a timeout task with the wrong decision schedule id causing timer processing to skip that timeout event. Also added an integration test for this use case.
samarabbas
force-pushed
the
missing-decision-timeout
branch
from
fdebcf4 to
4e4455e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using incorrect scheduleID for transient decisions on decision
started event. This happens if a new event comes in after a transient
decision is scheduled, but before it is started. We end up a creating a
timeout task with the wrong decision schedule id causing timer
processing to skip that timeout event.
Also added an integration test for this use case.
Fixes #887