Handle deletion of task during failover #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding awareness of failover info during transfer / timer task cleanup Note: missing persistence to database, the persistence to database of failover cursor should be done along with balk failover for performance.
samarabbas
approved these changes
Jul 23, 2018
| DomainNotificationVersion int64 | ||
| } | ||
|
|
||
| // TransferFailoverLevel contains corresponding start / end level | ||
| TransferFailoverLevel struct { |
There was a problem hiding this comment.
Can we also include CurrentLevel as a separate field to checkpoint current progress.
common/persistence/dataInterfaces.go
Outdated
| } | ||
|
|
||
| // TimerFailoverLevel contains domain IDs and corresponding start / end level | ||
| TimerFailoverLevel struct { |
There was a problem hiding this comment.
Can we also include CurrentLevel as a separate field to checkpoint current progress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: missing persistence to database, the persistence to database of
failover cursor should be done along with balk failover for performance.
solve #972