Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ti SDK 7.0.0.GA Update #95

Merged
merged 3 commits into from
Jan 11, 2018
Merged

Ti SDK 7.0.0.GA Update #95

merged 3 commits into from
Jan 11, 2018

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Dec 13, 2017

Ti SDK 7.0.0.GA Update

  • removed playservice files
  • removed proguard folder
  • added ti.playservice module
  • tested with Ti SDK 7 + Ti.Maps + Ti.Goosh
  • send normal push to device (foreground/background)
  • send push to topic (foreground/background)
  • updated README to show subscribe to topic (+ php example)

@kopiro
Copy link
Contributor

kopiro commented Dec 14, 2017

Hey, thank you! :)
Did you test the build?

@m1ga
Copy link
Contributor Author

m1ga commented Dec 14, 2017

I've ended up with [ERROR] E/ti.goosh.TiGooshModule: Attempt to invoke virtual method 'boolean java.lang.String.isEmpty()' on a null object reference but I thought it was just because I've added the module to an empty project and just used the democode without any GCM ID.

But it would make sense to change the whole library structure to ti.playservice because that is available with ti 7! Going to test that at the weekend and update the PR.

@m1ga m1ga changed the title Ti SDK 7.0.0.GA Update Ti SDK 7.0.0.GA Update [work in progress] Dec 14, 2017
@m1ga m1ga changed the title Ti SDK 7.0.0.GA Update [work in progress] Ti SDK 7.0.0.GA Update Dec 17, 2017
@m1ga
Copy link
Contributor Author

m1ga commented Dec 17, 2017

Now everything works fine with ti.playservices! Updated the initial post with all the changes

@m1ga m1ga mentioned this pull request Dec 17, 2017
@amigoni
Copy link

amigoni commented Dec 18, 2017

Awesome. Thanks so much. I am currently blocked from releasing our app due to conflicts with playservices, when do you think we'll have a this new version released?

@m1ga
Copy link
Contributor Author

m1ga commented Dec 18, 2017

@amigoni
Copy link

amigoni commented Dec 19, 2017

Awesome! Thanks so much! I really appreciate it.

@progress44 progress44 merged commit 21891e4 into caffeinalab:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants