Update Cake.MinVer add-in to target Cake v1.0.0-rc0001

cake-contrib · Dec 1, 2020 · 05c55fa · 05c55fa
1 parent 5b01d69
commit 05c55fa
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/src/Cake.MinVer/Cake.MinVer.csproj b/src/Cake.MinVer/Cake.MinVer.csproj
@@ -41,8 +41,9 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Cake.Core" Version="0.33.0" PrivateAssets="All" />
-    <PackageReference Include="Cake.Common" Version="0.33.0" PrivateAssets="All" />
+    <PackageReference Include="Cake.Core" Version="1.0.0-rc0001" />
+    <PackageReference Include="Cake.Common" Version="1.0.0-rc0001" />
+
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
   </ItemGroup>
 

diff --git a/src/Cake.MinVer/MinVerSettings.cs b/src/Cake.MinVer/MinVerSettings.cs
@@ -125,6 +125,7 @@ public MinVerSettings Clone()
                 NoWorkingDirectory = NoWorkingDirectory,
                 ArgumentCustomization = ArgumentCustomization,
                 EnvironmentVariables = EnvironmentVariables,
+                HandleExitCode = HandleExitCode,
             };
 
             return clone;

diff --git a/test/Cake.MinVer.Tests/Cake.MinVer.Tests.csproj b/test/Cake.MinVer.Tests/Cake.MinVer.Tests.csproj
@@ -6,9 +6,9 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Cake.Core" Version="0.33.0" />
-    <PackageReference Include="Cake.Common" Version="0.33.0" />
-    <PackageReference Include="Cake.Testing" Version="0.33.0" />
+    <PackageReference Include="Cake.Core" Version="1.0.0-rc0001" />
+    <PackageReference Include="Cake.Common" Version="1.0.0-rc0001" />
+    <PackageReference Include="Cake.Testing" Version="1.0.0-rc0001" />
 
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.5.0" />
     <PackageReference Include="xunit" Version="2.4.0" />

diff --git a/test/Cake.MinVer.Tests/MinVerSettingsTests.cs b/test/Cake.MinVer.Tests/MinVerSettingsTests.cs
@@ -48,6 +48,7 @@ public void Should_Shallow_Clone_All_Properties()
                 NoWorkingDirectory = true,
                 ArgumentCustomization = s => s,
                 EnvironmentVariables = new Dictionary<string, string> { { "MINVERTESTVAR", "SOMEVALUE" } },
+                HandleExitCode = i => false,
             };
 
             var actual = expected.Clone();
@@ -70,14 +71,15 @@ public void Should_Shallow_Clone_All_Properties()
             actual.NoWorkingDirectory.Should().Be(expected.NoWorkingDirectory);
             actual.ArgumentCustomization.Should().Be(expected.ArgumentCustomization);
             actual.EnvironmentVariables.Should().BeEquivalentTo(expected.EnvironmentVariables);
+            actual.HandleExitCode.Should().BeEquivalentTo(expected.HandleExitCode);
 
             var properties = typeof(MinVerSettings)
                 .GetProperties(BindingFlags.Public | BindingFlags.Instance | BindingFlags.FlattenHierarchy)
                 .Select(p => p.Name)
                 .ToList();
 
             // Sanity check & alarm to detect changes in properties that need to be considered in the cloning
-            properties.Should().HaveCount(17);
+            properties.Should().HaveCount(18);
         }
     }
 }