Add ability to execute MinVer as global tool and fallback logic #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default Cake.MinVer: - Tries to execute MinVer as a local tool (`dotnet minver`) - If executing the local tool fails, tries to execute as a global tool (`minver`) Setting `PreferGlobalTool` to `true` tells Cake.MinVer to invert the statement above, i.e.: - Tries to execute MinVer as a global tool (`minver`) - If executing the global tool fails, tries to execute as a local tool (`dotnet minver`) Setting `NoFallback` to `false` disables the fallback logic and Cake.MinVer will only attempt to execute one of the tools. Which one depends on the value of `PreferGlobalTool`. N.B.: If `ToolPath` is set - `PreferGlobalTool` is assumed `true` given that only global tools can have custom paths - `NoFallback` is assumed `true` given that a specific tool was provided and is expected to exist Useful information: https://docs.microsoft.com/en-us/dotnet/core/tools/global-tools
augustoproiete
added
bug
augustoproiete
force-pushed
the
run-as-global-tool-and-fallback-logic
branch
2 times, most recently
from
5e47bb0 to
32c404e
Compare
|
I have tested this locally and works perfect! Thanks a lot for the quick patch. |
|
That's great to hear @dario-griffo-cko! Thanks for testing it. Yes, Cake can download preview packages. You need to append |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5
By default Cake.MinVer:
dotnet minver)minver)Setting
PreferGlobalTooltotruetells Cake.MinVer to invert the statement above, i.e.:minver)dotnet minver)Setting
NoFallbacktofalsedisables the fallback logic and Cake.MinVer will only attemptto execute one of the tools. Which one depends on the value of
PreferGlobalTool.N.B.: If
ToolPathis setPreferGlobalToolis assumedtruegiven that only global tools can have custom pathsNoFallbackis assumedtruegiven that a specific tool was provided and is expected to existUseful information:
https://docs.microsoft.com/en-us/dotnet/core/tools/global-tools