Make the enabling of all Outline instances optional #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to have disabled
Outlinecomponents on your target objects in a scene at runtime and only enable them conditionally as needed. This allows you to turn outlines on and off without any allocations at runtime (as opposed to adding/destroying newOutlinecomponents at runtime when objects need to turn outlining on/off).The default is
true, so out-of-the-box, this PR doesn't change any behavior. You have to explicitly toggle this new option in the inspector of theOutlineEffectcomponent on your camera for this to change any behavior.