Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: DatePicker - do not call a function during render #18664

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: DatePicker - do not call a function during render #18664

wants to merge 2 commits into from
+4 −4

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Jan 14, 2025 •
edited
Loading

What does this PR do?

This fixes
Screenshot 2025-01-14 at 5 39 03 PM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Please use the latest Vercel preview and test please 🙏.

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 3:46pm
calcom-web-canary ⬜️ Ignored (Inspect) Jan 15, 2025 3:46pm

@graphite-app graphite-app bot requested a review from a team January 14, 2025 23:10
@hbjORbj hbjORbj changed the title chore: do not call a function during render chore: DatePicker - do not call a function during render Jan 14, 2025
@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 14, 2025
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label Jan 14, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 14, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/14/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

E2E results are ready!

eunjae-lee
eunjae-lee previously approved these changes Jan 15, 2025
View reviewed changes
@eunjae-lee eunjae-lee self-requested a review January 15, 2025 15:42
@hbjORbj hbjORbj marked this pull request as draft January 15, 2025 15:45
@github-actions GitHub Actions
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunjae-lee eunjae-lee Awaiting requested review from eunjae-lee

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking consumer core area: core, team members only ready-for-e2e Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @eunjae-lee @keithwillcode