Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tech debt clearing - simplify isThemeSupported usage #18746

Merged
merged 1 commit into from
Jan 20, 2025
Merged

chore: tech debt clearing - simplify isThemeSupported usage #18746

merged 1 commit into from
Jan 20, 2025

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Jan 18, 2025 •
edited
Loading

What does this PR do?

  • App Router currently checks if the Component has a prop called isThemeSupported.
  • /auth/setup is the only route withisThemeSupported = false. So I created a simple hook.
Screenshot 2025-01-18 at 6 03 24 PM - `/auth/setup` is currently in Pages router btw, so this change doesn't affect production

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel Vercel
Copy link

vercel bot commented Jan 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2025 11:10pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2025 11:10pm

@graphite-app graphite-app bot requested a review from a team January 18, 2025 23:07
@keithwillcode keithwillcode added consumer core area: core, team members only labels Jan 18, 2025
@hbjORbj hbjORbj force-pushed the chore/tech-debt-clearing-simplify-isThemeSupported-usage branch from 71e7208 to cff3933 Compare January 18, 2025 23:08
hbjORbj
hbjORbj commented Jan 18, 2025
View reviewed changes
apps/web/lib/hooks/useIsThemeSupported.ts

import { usePathname } from "next/navigation";

const THEME_UNSUPPORTED_ROUTES = ["/auth/setup"];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-18 at 6 03 24 PM

auth/setup is the only route with false value for isThemeSupported

@hbjORbj hbjORbj changed the title chore: tech debt clearing simplify isthemesupported usage chore: tech debt clearing - simplify isThemeSupported usage Jan 18, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 18, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/18/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

@hbjORbj hbjORbj enabled auto-merge (squash) January 18, 2025 23:50
@Udit-takkar Udit-takkar added this to the v5.0 milestone Jan 20, 2025
@hbjORbj hbjORbj merged commit 4424b2a into main Jan 20, 2025
48 of 66 checks passed
@hbjORbj hbjORbj deleted the chore/tech-debt-clearing-simplify-isThemeSupported-usage branch January 20, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar approved these changes

Assignees
No one assigned
Labels
consumer core area: core, team members only ready-for-e2e 💻 refactor
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @Udit-takkar @keithwillcode