Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resize columns when column visibility changes #19172

Merged
merged 3 commits into from
Feb 7, 2025
Merged

fix: resize columns when column visibility changes #19172

merged 3 commits into from
Feb 7, 2025
+6 −3

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Feb 7, 2025 •
edited
Loading

What does this PR do?

This PR resizes columns when a column is hidden or shown.

  • Fixes CAL-5090

Before

Screenshot.2025-02-07.at.15.46.33.mp4

After

Screenshot.2025-02-07.at.15.40.52.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • All the columns are resized when a column is hidden or shown.
  • Column resizing should still work well.

@linear Linear
Copy link

linear bot commented Feb 7, 2025

CAL-5090 re-adjust column sizes when column visibility changes

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 7, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 2:52pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 2:52pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 2:52pm

@eunjae-lee eunjae-lee marked this pull request as ready for review February 7, 2025 15:03
@graphite-app graphite-app bot requested a review from a team February 7, 2025 15:03
@dosubot dosubot bot added the 🐛 bug Something isn't working label Feb 7, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 7, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/07/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/07/25)

1 label was added to this PR based on Keith Williams's automation.

PeerRich
PeerRich approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great change!

@PeerRich PeerRich enabled auto-merge (squash) February 7, 2025 16:52
@PeerRich PeerRich merged commit 403cfeb into main Feb 7, 2025
80 of 82 checks passed
@PeerRich PeerRich deleted the eunjae/cal-5090-re-adjust-column-sizes-when-column-visibility-changes branch February 7, 2025 17:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

E2E results are ready!

@keithwillcode
Copy link
Contributor

What a nice improvement 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eunjae-lee @keithwillcode @PeerRich