Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: null check for useSearchParams() #19175

Merged
merged 1 commit into from
Feb 7, 2025
Merged

fix: null check for useSearchParams() #19175

merged 1 commit into from
Feb 7, 2025

Conversation

eunjae-lee
Copy link
Contributor

What does this PR do?

The return of useSearchParams() can be falsey.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 7, 2025
@eunjae-lee eunjae-lee marked this pull request as ready for review February 7, 2025 14:59
@graphite-app graphite-app bot requested a review from a team February 7, 2025 15:00
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 7, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/07/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/07/25)

1 label was added to this PR based on Keith Williams's automation.

@dosubot dosubot bot added the 🐛 bug Something isn't working label Feb 7, 2025
@PeerRich PeerRich enabled auto-merge (squash) February 7, 2025 15:01
@vercel Vercel
Copy link

vercel bot commented Feb 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Feb 7, 2025 3:06pm
calcom-web-canary ⬜️ Ignored (Inspect) Feb 7, 2025 3:06pm

@PeerRich PeerRich merged commit 5d2c8a4 into main Feb 7, 2025
39 of 81 checks passed
@PeerRich PeerRich deleted the fix/use-search-params branch February 7, 2025 15:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eunjae-lee @PeerRich @keithwillcode