-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LeftNav] Feature/swipe to open #868
Conversation
@pomerantsev I think it works pretty well. One thing that does feel weird is that the nav menu will open on a left swipe as well as a right swipe. It seems like it should only open on a swipe to the right? Same issue with closing the menu, it should only close with a swipe to the left. But, that issue seems to have always been there. |
@hai-cea I created an issue #900. |
@pomerantsev ok looks great 👍 Thanks! |
[LeftNav] Feature/swipe to open
Nice one! Looking forward to the next release :) |
I'm getting all kinds of weird behavior with this. I swipe the menu in from the left, I tap next to it (it closes automatically), I tap anywhere again, it pops open again (without the dark background overlay), and then it is in a weird state where tapping on it closes it (without animation). |
@CumpsD thanks for noticing it. |
Resolves #848.