fix: use same class names in dev and prod. fixes #147 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
force-pushed
the
@satya164/class-name
branch
from
94e66a0 to
b77288d
Compare
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 97.58% 97.57% -0.01%
==========================================
Files 19 19
Lines 414 413 -1
Branches 87 85 -2
==========================================
- Hits 404 403 -1
Misses 10 10
Continue to review full report at Codecov.
|
satya164
force-pushed
the
@satya164/class-name
branch
from
b77288d to
bfc60ab
Compare
satya164
commented
Nov 10, 2017
| @@ -72,7 +72,7 @@ export default (babel: BabelCore) => { | |||
| token.value.trim() === 'linaria-preval' | |||
| ); | |||
| state.foundLinariaTaggedLiterals = false; | |||
| state.filename = state.file.opts.filename; | |||
| state.filename = relativeToCwd(state.file.opts.filename); | |||
There was a problem hiding this comment.
I changed this to use relative path for consistent file names across different machines, such as CI and local.
satya164
force-pushed
the
@satya164/class-name
branch
from
bfc60ab to
ed0f799
Compare
zamotany
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.