-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: scope option for libraries #369
Conversation
53206bb
to
bac422f
Compare
Hey @chrisbateman, thank you for your pull request 🤗. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Looks good to me. Any harm if we do this by default instead of accepting an option?
My scope idea was to prefix the class name in the generated CSS, like .my-library .cs56ghgd { ... }
, so probably shouldn't use scope
for the config name, but I also wanted what you did in the PR.
Gotcha – that'd work for me! I could make that update later today – any suggestions for the config name? |
new classPrefix option Closes callstack#299. See also callstack#208, callstack#178
@satya164 Let me know if this is more like what you were thinking of! |
Just a heads-up: we're working on TS migration in #398 and will let you know once we're done. Would you be so kind and bear with us until it's ready and rebase then? |
@satya164 can we merge it after TS migration? Could you take a look? |
@thymikee can do - thanks for the update! |
Hi, @chrisbateman Do you have the capacity and will to refactor this to the point it would be possible to merge it to current |
How is this different from setting the existing |
Lol I didn't notice that :o Looks like |
Summary
see #299, #208, #178 and updates to docs/CONFIGURATION.md.
I wasn't sure what kind of API you had in mind for this feature, so I won't be offended if you want to go in a different direction!
Test plan
Added some Jest tests, linked locally and tested scope: false/true/"custom" and verified that different class names were generated for each.