fix: missing swc config in RN & NM rules (#843)

* fix: missing swc config in RN & NM rules * chore: update templates * chore: apply the change in related configs * chore: changeset * chore: undo bugfixes change
callstack · Dec 30, 2024 · 3029ab6 · 3029ab6
1 parent d8eb77e
commit 3029ab6
Show file tree

Hide file tree

Showing 10 changed files with 32 additions and 4 deletions.
diff --git a/.changeset/nervous-wasps-applaud.md b/.changeset/nervous-wasps-applaud.md
@@ -0,0 +1,5 @@
+---
+"@callstack/repack": patch
+---
+
+Fix missing config for swc loader rules
diff --git a/apps/tester-app/rspack.config.mjs b/apps/tester-app/rspack.config.mjs
@@ -64,6 +64,7 @@ export default (env) => {
             /** @type {import('@rspack/core').SwcLoaderOptions} */
             options: {
               env: {
+                loose: true,
                 targets: {
                   'react-native': '0.74',
                 },

diff --git a/apps/tester-federation-v2/rspack.config.host-app.mjs b/apps/tester-federation-v2/rspack.config.host-app.mjs
@@ -58,7 +58,10 @@ export default (env) => {
           use: {
             loader: 'builtin:swc-loader',
             options: {
-              env: { targets: { 'react-native': '0.74' } },
+              env: {
+                loose: true,
+                targets: { 'react-native': '0.74' },
+              },
               jsc: { externalHelpers: true },
             },
           },
@@ -74,6 +77,7 @@ export default (env) => {
             options: {
               sourceMaps: true,
               env: {
+                loose: true,
                 targets: { 'react-native': '0.74' },
               },
               jsc: {

diff --git a/apps/tester-federation-v2/rspack.config.mini-app.mjs b/apps/tester-federation-v2/rspack.config.mini-app.mjs
@@ -57,7 +57,10 @@ export default (env) => {
           use: {
             loader: 'builtin:swc-loader',
             options: {
-              env: { targets: { 'react-native': '0.74' } },
+              env: {
+                loose: true,
+                targets: { 'react-native': '0.74' },
+              },
               jsc: { externalHelpers: true },
             },
           },
@@ -73,6 +76,7 @@ export default (env) => {
             options: {
               sourceMaps: true,
               env: {
+                loose: true,
                 targets: { 'react-native': '0.74' },
               },
               jsc: {

diff --git a/apps/tester-federation/rspack.config.host-app.mjs b/apps/tester-federation/rspack.config.host-app.mjs
@@ -64,7 +64,10 @@ export default (env) => {
           use: {
             loader: 'builtin:swc-loader',
             options: {
-              env: { targets: { 'react-native': '0.74' } },
+              env: {
+                loose: true,
+                targets: { 'react-native': '0.74' },
+              },
               jsc: { externalHelpers: true },
             },
           },
@@ -80,6 +83,7 @@ export default (env) => {
             options: {
               sourceMaps: true,
               env: {
+                loose: true,
                 targets: { 'react-native': '0.74' },
               },
               jsc: {

diff --git a/apps/tester-federation/rspack.config.mini-app.mjs b/apps/tester-federation/rspack.config.mini-app.mjs
@@ -63,7 +63,10 @@ export default (env) => {
           use: {
             loader: 'builtin:swc-loader',
             options: {
-              env: { targets: { 'react-native': '0.74' } },
+              env: {
+                loose: true,
+                targets: { 'react-native': '0.74' },
+              },
               jsc: { externalHelpers: true },
             },
           },
@@ -79,6 +82,7 @@ export default (env) => {
             options: {
               sourceMaps: true,
               env: {
+                loose: true,
                 targets: { 'react-native': '0.74' },
               },
               jsc: {

diff --git a/packages/repack/src/rules/nodeModulesLoadingRules.ts b/packages/repack/src/rules/nodeModulesLoadingRules.ts
@@ -5,6 +5,7 @@ const makeSwcLoaderConfig = (syntax: 'js' | 'ts', jsx: boolean) => ({
   loader: 'builtin:swc-loader',
   options: {
     env: {
+      loose: true,
       targets: { 'react-native': '0.74' },
     },
     jsc: {
@@ -24,6 +25,7 @@ const makeSwcLoaderConfig = (syntax: 'js' | 'ts', jsx: boolean) => ({
       type: 'commonjs',
       strict: false,
       strictMode: false,
+      noInterop: false,
     },
   },
 });

diff --git a/packages/repack/src/rules/reactNativeLoadingRules.ts b/packages/repack/src/rules/reactNativeLoadingRules.ts
@@ -23,6 +23,7 @@ export const REACT_NATIVE_LOADING_RULES: RuleSetRule = {
       loader: 'builtin:swc-loader',
       options: {
         env: {
+          loose: true,
           targets: { 'react-native': '0.74' },
         },
         jsc: {
@@ -47,6 +48,7 @@ export const REACT_NATIVE_LOADING_RULES: RuleSetRule = {
           strict: false,
           strictMode: false,
           lazy: REACT_NATIVE_LAZY_IMPORTS,
+          noInterop: false,
         },
       },
     },

diff --git a/templates_v5/rspack.config.cjs b/templates_v5/rspack.config.cjs
@@ -104,6 +104,7 @@ module.exports = (env) => {
             loader: 'builtin:swc-loader',
             options: {
               env: {
+                loose: true,
                 targets: {
                   'react-native': '0.74',
                 },

diff --git a/templates_v5/rspack.config.mjs b/templates_v5/rspack.config.mjs
@@ -102,6 +102,7 @@ export default (env) => {
             /** @type {import('@rspack/core').SwcLoaderOptions} */
             options: {
               env: {
+                loose: true,
                 targets: {
                   'react-native': '0.74',
                 },