fix: verbose flag in start command (#779)

* fix: verbose flag in start command * chore: add changset * chore: update podfile locks * fix: dont show http request when silent flag is active
callstack · Nov 3, 2024 · 679bcd8 · 679bcd8
1 parent 2344162
commit 679bcd8
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 18 deletions.
diff --git a/.changeset/odd-cars-yawn.md b/.changeset/odd-cars-yawn.md
@@ -0,0 +1,5 @@
+---
+"@callstack/repack": patch
+---
+
+More intuitive behaviour of `--verbose` flag in start command
diff --git a/apps/tester-app/ios/Podfile.lock b/apps/tester-app/ios/Podfile.lock
@@ -1,6 +1,6 @@
 PODS:
   - boost (1.84.0)
-  - callstack-repack (5.0.0-alpha.0):
+  - callstack-repack (5.0.0-rc.0):
     - DoubleConversion
     - glog
     - hermes-engine
@@ -1852,7 +1852,7 @@ EXTERNAL SOURCES:
 
 SPEC CHECKSUMS:
   boost: 1dca942403ed9342f98334bf4c3621f011aa7946
-  callstack-repack: 101158626fc46ba3d24c4b56d81188c12427b49b
+  callstack-repack: 75464b0e26467fc4a7236373399bc0fc2281f495
   DoubleConversion: f16ae600a246532c4020132d54af21d0ddb2a385
   FBLazyVector: 319d66555ce769137a84559a19fb8197733a68e1
   fmt: 10c6e61f4be25dc963c36bd73fc7b1705fe975be

diff --git a/apps/tester-federation-v2/ios/Podfile.lock b/apps/tester-federation-v2/ios/Podfile.lock
@@ -1,6 +1,6 @@
 PODS:
   - boost (1.84.0)
-  - callstack-repack (5.0.0-alpha.0):
+  - callstack-repack (5.0.0-rc.0):
     - DoubleConversion
     - glog
     - hermes-engine
@@ -1895,7 +1895,7 @@ EXTERNAL SOURCES:
 
 SPEC CHECKSUMS:
   boost: 1dca942403ed9342f98334bf4c3621f011aa7946
-  callstack-repack: 101158626fc46ba3d24c4b56d81188c12427b49b
+  callstack-repack: 75464b0e26467fc4a7236373399bc0fc2281f495
   DoubleConversion: f16ae600a246532c4020132d54af21d0ddb2a385
   FBLazyVector: 319d66555ce769137a84559a19fb8197733a68e1
   fmt: 10c6e61f4be25dc963c36bd73fc7b1705fe975be

diff --git a/apps/tester-federation/ios/Podfile.lock b/apps/tester-federation/ios/Podfile.lock
@@ -1,6 +1,6 @@
 PODS:
   - boost (1.84.0)
-  - callstack-repack (5.0.0-alpha.0):
+  - callstack-repack (5.0.0-rc.0):
     - DoubleConversion
     - glog
     - hermes-engine
@@ -1919,7 +1919,7 @@ EXTERNAL SOURCES:
 
 SPEC CHECKSUMS:
   boost: 1dca942403ed9342f98334bf4c3621f011aa7946
-  callstack-repack: 101158626fc46ba3d24c4b56d81188c12427b49b
+  callstack-repack: 75464b0e26467fc4a7236373399bc0fc2281f495
   DoubleConversion: f16ae600a246532c4020132d54af21d0ddb2a385
   FBLazyVector: 319d66555ce769137a84559a19fb8197733a68e1
   fmt: 10c6e61f4be25dc963c36bd73fc7b1705fe975be

diff --git a/packages/repack/src/commands/rspack/start.ts b/packages/repack/src/commands/rspack/start.ts
@@ -57,14 +57,12 @@ export async function start(
   }
 
   const reversePort = reversePortArg ?? process.argv.includes('--reverse-port');
+
   const isSilent = args.silent;
-  const isVerbose = isSilent
-    ? false
-    : // TODO fix (jbroma)
-      // biome-ignore format: fix in a separate PR
-      args.verbose ?? process.argv.includes('--verbose');
+  const isVerbose = args.verbose;
+
+  const showHttpRequests = isSilent ? false : isVerbose || args.logRequests;
 
-  const showHttpRequests = isVerbose || args.logRequests;
   const reporter = composeReporters(
     [
       new ConsoleReporter({

diff --git a/packages/repack/src/commands/webpack/start.ts b/packages/repack/src/commands/webpack/start.ts
@@ -56,14 +56,12 @@ export async function start(_: string[], config: Config, args: StartArguments) {
   }
 
   const reversePort = reversePortArg ?? process.argv.includes('--reverse-port');
+
   const isSilent = args.silent;
-  const isVerbose = isSilent
-    ? false
-    : // TODO fix in a separate PR (jbroma)
-      // biome-ignore format: fix in a separate PR
-      args.verbose ?? process.argv.includes('--verbose');
+  const isVerbose = args.verbose;
+
+  const showHttpRequests = isSilent ? false : isVerbose || args.logRequests;
 
-  const showHttpRequests = isVerbose || args.logRequests;
   const reporter = composeReporters(
     [
       new ConsoleReporter({