fix(repack): fix webpack's ModuleFederationPlugin configuration (#444)

* fix(repack): pass options to webpack ModuleFederationPlugin explictly * chore: add changeset
callstack · Oct 11, 2023 · 88dc11f · 88dc11f
1 parent 304b8f4
commit 88dc11f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/.changeset/honest-coins-ring.md b/.changeset/honest-coins-ring.md
@@ -0,0 +1,5 @@
+---
+"@callstack/repack": patch
+---
+
+Fix ValidationError in ModuleFederationPlugin caused by reactNativeDeepImports prop
diff --git a/packages/repack/src/webpack/plugins/ModuleFederationPlugin.ts b/packages/repack/src/webpack/plugins/ModuleFederationPlugin.ts
@@ -244,7 +244,7 @@ export class ModuleFederationPlugin implements WebpackPlugin {
     );
 
     new container.ModuleFederationPlugin({
-      ...this.config,
+      exposes: this.config.exposes,
       filename:
         this.config.filename ?? this.config.exposes
           ? `${this.config.name}.container.bundle`
@@ -256,8 +256,12 @@ export class ModuleFederationPlugin implements WebpackPlugin {
             ...this.config.library,
           }
         : undefined,
+      name: this.config.name,
       shared: sharedDependencies,
+      shareScope: this.config.shareScope,
       remotes,
+      remoteType: this.config.remoteType,
+      runtime: this.config.runtime,
     }).apply(compiler);
   }
 }