fix: finding path to webpack.config.mjs on Windows (#723)

* fix: check filename and not raw candidate * refactor: use pathToFileURL, remove redundant absolute path check * chore: add changeset
callstack · Aug 28, 2024 · d3c96b8 · d3c96b8
1 parent 912942d
commit d3c96b8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/.changeset/friendly-melons-argue.md b/.changeset/friendly-melons-argue.md
@@ -0,0 +1,5 @@
+---
+'@callstack/repack': patch
+---
+
+Fix reading `webpack.config.mjs` on Windows
diff --git a/packages/repack/src/commands/utils/getWebpackConfigPath.ts b/packages/repack/src/commands/utils/getWebpackConfigPath.ts
@@ -1,6 +1,7 @@
-import path from 'path';
-import fs from 'fs';
-import Os from 'os';
+import path from 'node:path';
+import fs from 'node:fs';
+import os from 'node:os';
+import url from 'node:url';
 
 // Supports the same files as Webpack CLI.
 const DEFAULT_WEBPACK_CONFIG_LOCATIONS = [
@@ -22,13 +23,10 @@ export function getWebpackConfigPath(root: string, customPath?: string) {
     const filename = path.isAbsolute(candidate)
       ? candidate
       : path.join(root, candidate);
+
     if (fs.existsSync(filename)) {
-      if (
-        path.isAbsolute(candidate) &&
-        candidate.endsWith('.mjs') &&
-        Os.platform() === 'win32'
-      ) {
-        return `file:\\${filename}`;
+      if (path.extname(filename) === '.mjs' && os.platform() === 'win32') {
+        return url.pathToFileURL(filename).href;
       } else {
         return filename;
       }