Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Order of operations inside ModuleFederationPlugin #360

Closed
jbroma opened this issue May 22, 2023 · 0 comments · Fixed by #775
Closed

Bug: Order of operations inside ModuleFederationPlugin #360

jbroma opened this issue May 22, 2023 · 0 comments · Fixed by #775
Assignees
Labels
area:repack The issue is about logic/code inside of Re.Pack. type:bug A bug report.

Comments

@jbroma
Copy link
Member

jbroma commented May 22, 2023

Description

Inside of ModuleFederationPlugin we have this piece of code:

// ...
new container.ModuleFederationPlugin({
      ...this.config,
      filename:
        this.config.filename ?? this.config.exposes
          ? `${this.config.name}.container.bundle`
          : undefined,
// ...

Filename should evaluate to this.config.filename, but instead it evaluates to name.container.bundle whenever this.config.exposes is present, which is clearly an order of operations issue.

When using ModuleFederation, ScriptManager's resolver use .container.bundle as a way to differentiate other chunks from container chunks. Therefore before fixing this issue, we need to find a way to differentiate them differently.

@jbroma jbroma added type:bug A bug report. area:repack The issue is about logic/code inside of Re.Pack. labels May 22, 2023
@github-actions github-actions bot added the Stale label Dec 21, 2023
@github-actions github-actions bot closed this as completed Jan 4, 2024
@jbroma jbroma removed the Stale label Nov 1, 2024
@jbroma jbroma self-assigned this Nov 1, 2024
@jbroma jbroma reopened this Nov 1, 2024
@callstack callstack deleted a comment from github-actions bot Nov 1, 2024
@callstack callstack deleted a comment from github-actions bot Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:repack The issue is about logic/code inside of Re.Pack. type:bug A bug report.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant