Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow for custom federated filename in MF1 Plugin #775

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Nov 1, 2024

Summary

Closes #360

  • - fix order of operation bug
  • - add test cases to cover that
  • - allow for custom extension in createURLResolver to account for custom extension

Test plan

  • - tests pass

Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: f206242

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/repack Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Nov 1, 2024 6:39pm

@jbroma jbroma merged commit 76738de into main Nov 1, 2024
5 checks passed
@jbroma jbroma deleted the fix/mf-order-of-operation branch November 1, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Order of operations inside ModuleFederationPlugin
1 participant