Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the description of start and bundle commands #538

Closed
jbroma opened this issue Apr 4, 2024 · 5 comments · Fixed by #656
Closed

Adjust the description of start and bundle commands #538

jbroma opened this issue Apr 4, 2024 · 5 comments · Fixed by #656
Assignees
@barttom
Labels
area:repack The issue is about logic/code inside of Re.Pack. help wanted especially welcoming for external contributions type:feature Proposal or idea for a new feature or enhancement.

Comments

@jbroma
Copy link
Member

jbroma commented Apr 4, 2024

Describe the feature

Adjust the description of commands so that they don't include unsupported flags

Motivation

Currently, we copy the the command descriptions from CLI commands and add our own flags. We should also adjust the copied descriptions, so that the --help output is up to date.

Related Issues

proposed by @szymonrybczak in #537
@jbroma jbroma added type:feature Proposal or idea for a new feature or enhancement. area:repack The issue is about logic/code inside of Re.Pack. help wanted especially welcoming for external contributions labels Apr 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

This issue has been marked as stale because it has been inactive for 30 days. Please update this issue or it will be automatically closed in 14 days.

@github-actions github-actions bot added the Stale label May 5, 2024
@jbroma jbroma removed the Stale label May 17, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive for 30 days. Please update this issue or it will be automatically closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 17, 2024
@szymonrybczak
Copy link
Contributor

Is this issue still valid? What option do we miss inside Re.Pack CLI commands? 🤔

@jbroma
Copy link
Member Author

jbroma commented Jun 17, 2024

It's still valid, hard to tell what's missing, haven't looked at that yet - we simply need to go through every flag and check if it makes sense in Re.Pack and/or add missing ones (specific to Re.Pack)

@jbroma jbroma removed the Stale label Jun 17, 2024
@barttom barttom self-assigned this Jun 25, 2024
@barttom barttom mentioned this issue Jul 1, 2024
Merged
@barttom
Copy link
Contributor

barttom commented Jul 1, 2024

@jbroma @szymonrybczak when You have a moment :)
#656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barttom barttom

Labels
area:repack The issue is about logic/code inside of Re.Pack. help wanted especially welcoming for external contributions type:feature Proposal or idea for a new feature or enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove unsuported commands from doc barttom/repack
3 participants
@barttom @jbroma @szymonrybczak